impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()
Date Thu, 25 May 2017 23:56:12 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I think there would be some benefit in having ReleaseResources() called in the same place
for all queries, but agree that this solves the bug.

http://gerrit.cloudera.org:8080/#/c/6897/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 918:   DCHECK(!query_status_.ok());
Add a TODO that this is weird, since CancelInternal() is called on the successful query path
as well (per UnregisterQuery()).


-- 
To view, visit http://gerrit.cloudera.org:8080/6897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I457a6424a0255c137336c4bc01a6e7ed830d18c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message