impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5232: Parquet reader error message prints memory address instead of value
Date Thu, 25 May 2017 19:17:13 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of
value
......................................................................


IMPALA-5232: Parquet reader error message prints memory address instead of value

Changed the argument of the message to print the size instead of
the memory location.

Testing: Automating the test would be non-trivial as it would require 
generating a corrupt parquet file to trigger the error condition. Also, 
the test would only have to check a change in the error message and not 
the control flow. Manually tested the error message by modifying the 
value of num_bytes and performing a select on a table in parquet format.
Tested both condition with the following values:
	- num_bytes = -1
	- num_bytes = *data_size + 1

Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70
Reviewed-on: http://gerrit.cloudera.org:8080/6982
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Sailesh Mukil: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pooja Nilangekar <pooja.nilangekar@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilangekar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message