impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function
Date Thu, 25 May 2017 18:11:09 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-5326: [DOCS] Document REPLACE() function

Patch Set 2:

File docs/topics/impala_new_features.xml:

PS1, Line 70: A new function, <codeph>replace()</codeph>, which is faster than
            :             <codeph>regexp_replace()</codeph> for simple string
            :             See <xref ke
> Proposal:
Done, with minor wordsmithing. (Editorial conventions to avoid passive voice & future
File docs/topics/impala_string_functions.xml:

PS1, Line 890: -
> Maybe best to alias the column/expression or use a different example.  This

PS1, Line 890: -
> How about replace('hello world', '0', 'z') and just illustrate the original

PS1, Line 890: -
> The lowercase folding is just something for the column heading/alias.

PS1, Line 890: -
> This looks like a bug. It might be worth calling out the oddness here that 
I'll call out case-sensitivity in text rather than an example, as Zach suggested.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib576fba03673bd6708a46f45c8388477b25e34da
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <>
Gerrit-Reviewer: Greg Rahn <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: John Russell <>
Gerrit-Reviewer: Zach Amsden <>
Gerrit-HasComments: Yes

View raw message