impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5354: INSERT hints for Kudu tables
Date Thu, 25 May 2017 15:59:44 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5354: INSERT hints for Kudu tables
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6980/1/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

PS1, Line 502: deringExprs.add(
             :             KuduUtil.createPartitionEx
> 1 line
Done


PS1, Line 504: orderingExprs.addAll(insertStmt.getPrimaryKeyExprs());
             :       }
             :     } else if (insertStmt.hasClusteredHint() || !insertStmt.getSortExprs().isEmpty())
{
             :       // NOTE: If the table has a 'sort.colum
> how about refactoring this to KuduUtil to avoid duplicate code w/ Distribut
Done


http://gerrit.cloudera.org:8080/#/c/6980/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu-upsert.test
File testdata/workloads/functional-planner/queries/PlannerTest/kudu-upsert.test:

Line 213: ====
> add test with both hints
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbd1ef977446ffee157ce3ce0b476e1f08a75d05
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message