impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04
Date Thu, 25 May 2017 05:10:22 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04
......................................................................


Patch Set 1:

So, I'm a little concerned about this. The datetime being installed here isn't the stdlib
datetime. It's a thirdparty module from Zope. When you install it, you also get other dependencies...

   Installing collected packages: zope.interface, pytz, datetime
   Successfully installed datetime-4.2 pytz-2017.2 zope.interface-4.4.1

And if you look at the comments in the setup.py for that file, this is included:

   description="""\
   This package provides a DateTime data type, as known from Zope 2.
   Unless you need to communicate with Zope 2 APIs, you're probably
   better off using Python's built-in datetime module.""".replace('\n', ' ')

https://github.com/zopefoundation/DateTime/blob/master/setup.py

-- 
To view, visit http://gerrit.cloudera.org:8080/6989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41501d273967dc1d57d366a145766a67b2dbbaa0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message