impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pooja Nilangekar (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5232: Parquet reader error message prints memory address instead of value
Date Wed, 24 May 2017 23:41:57 GMT
Pooja Nilangekar has uploaded a new patch set (#2).

Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of
value
......................................................................

IMPALA-5232: Parquet reader error message prints memory address
instead of value

Changed the argument of the message to print the size instead of
the memory location.
Testing: Manually tested the error message by modifying the value
of num_bytes and performing a select on a table in parquet format.
Tested both condition with the following values:
	- num_bytes = -1
	- num_bytes = *data_size + 1

Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/6982/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pooja Nilangekar <pooja.nilangekar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message