impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5232: Parquet reader error message prints memory address instead of value
Date Wed, 24 May 2017 23:21:03 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of
value
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6982/1//COMMIT_MSG
Commit Message:

Line 9: Changed the argument of the message to print the size instead of the memory location.
We usually try to keep the commit message line lengths to 70 characters per line. This is
so that the message fits into the gerrit Web UI's commit message box.

(It doesn't matter if only the title goes over 70 characters though)


Line 10: 
Can you mention how you tested it over here?

You can say "Testing: Tested manually by doing blah blah" and also give some reasoning as
to why you cannot add an automated test for this.

You can look at one of my previous commit messages to get a decent idea:
https://gerrit.cloudera.org/#/c/6886/


-- 
To view, visit http://gerrit.cloudera.org:8080/6982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pooja Nilangekar <pooja.nilangekar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message