impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values
Date Wed, 24 May 2017 22:59:29 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5338: Fix Kudu timestamp column default values
......................................................................


Patch Set 1:

(1 comment)

Responding to Marcel's higher level comment first, I'll address the code comments assuming
we don't change approaches.

http://gerrit.cloudera.org:8080/#/c/6936/1//COMMIT_MSG
Commit Message:

Line 19: will be a BIGINT if the column type is TIMESTAMP. It is only
> what if you stored the default as a timestamp literal instead (and then con
The problem is that then the catalog would need to do the conversion from TimestampValue to
unixtime micros. That would get hairy because the conversion function exists as a UDF, and
it'd be really weird for the catalog to start calling UDFs. It could be exposed explicitly
over JNI but that's also not ideal.

This approach does involve some special casing, but I think at least we can be clear about
when the conversion happens and what is stored on the KuduColumn class.


-- 
To view, visit http://gerrit.cloudera.org:8080/6936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I655910fb4805bb204a999627fa9f68e43ea8aaf2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message