impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5354: INSERT hints for Kudu tables
Date Wed, 24 May 2017 22:53:15 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5354: INSERT hints for Kudu tables
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6980/1/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

PS1, Line 502: !insertStmt.hasNoClusteredHint()
             :           && !ctx_.isSingleNodeExec())
1 line


PS1, Line 504: Expr kuduPartitionExpr = new KuduPartitionExpr(DescriptorTable.TABLE_SINK_ID,
             :             (KuduTable) insertStmt.getTargetTable(),
             :             Lists.newArrayList(insertStmt.getPartitionKeyExprs()),
             :             insertStmt.getPartitionColPos());
how about refactoring this to KuduUtil to avoid duplicate code w/ DistributedPlan which could
get out of sync later?


-- 
To view, visit http://gerrit.cloudera.org:8080/6980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbd1ef977446ffee157ce3ce0b476e1f08a75d05
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message