impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function
Date Wed, 24 May 2017 22:17:30 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-5326: [DOCS] Document REPLACE() function
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

PS1, Line 890: o
> Maybe best to alias the column/expression or use a different example.  This
How about replace('hello world', '0', 'z') and just illustrate the original string is returned
if nothing matches.  Show case sensitivity is not very useful, I think it is sufficient just
to mention it.

One other notable behavior - patterns which match their replacement do not consider the replacement
for further expansion.  So replace('foo', 'foo', 'foofoo') results in 'foofoo', not a heap
/ stack overflow.


-- 
To view, visit http://gerrit.cloudera.org:8080/6979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib576fba03673bd6708a46f45c8388477b25e34da
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message