impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.
Date Wed, 24 May 2017 20:39:32 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables.
......................................................................


Patch Set 4:

(2 comments)

I'm going to rebase and fix the remaining tests with SHOW PARTITIONS / SHOW TABLE STATS.

http://gerrit.cloudera.org:8080/#/c/6840/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

PS4, Line 624: Otherwise, the input cardinality is based on the per-partition row count stats
             :    * and/or the table-level row count stats, depending on which of those are
available.
             :    * Partitions without stats are ignored.
> That part describes the logic in computeCardinalities. Sure you want to lea
Everything under "Row count extrapolation" describes the intended behavior. The logic really
is spread between the two functions, so I chose to leave this comment at the top level.


http://gerrit.cloudera.org:8080/#/c/6840/3/tests/metadata/test_explain.py
File tests/metadata/test_explain.py:

PS3, Line 127: 50
> There are definitely ways to improve this. If you haven't done so, can you 
Filed IMPALA-5360 and IMPALA-5361.


-- 
To view, visit http://gerrit.cloudera.org:8080/6840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I972c8a03ed70211734631a7dc9085cb33622ebc4
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message