impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS
Date Wed, 24 May 2017 17:01:38 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5333: Add support for Impala to work with ADLS
......................................................................


Patch Set 5:

(2 comments)

I just found that a single test was slipping through the cracks and erroring out. It didn't
show up as failed, but as an error, so I didn't notice it on the dev environment when the
entire test suite ran. It had to do with LOAD DATA not working for ADLS. The test was:
metadata/test_load.py

I've fixed it now and also found a small bug for S3A, which I will fix in a separate patch.
I've made sure that all the tests run well again, and I'm running the test suite rebased on
top of the latest commit now.

I've marked the places in comments where I made changes.

http://gerrit.cloudera.org:8080/#/c/6910/5/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java
File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java:

Line 155:       // TODO: Disable permission checking for S3A as well (HADOOP-13892)
This was a longstanding 'bug' even for S3A. I'll fix it for that in a separate patch.


http://gerrit.cloudera.org:8080/#/c/6910/5/tests/util/adls_util.py
File tests/util/adls_util.py:

Line 54:   def ls(self, path):
The ls() function was returning the entire path of the file, which broke a single test's expectations.


-- 
To view, visit http://gerrit.cloudera.org:8080/6910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic56b9988b32a330443f24c44f9cb2c80842f7542
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message