impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Loads all TPC-DS tables
Date Tue, 23 May 2017 21:55:31 GMT
Michael Ho has posted comments on this change.

Change subject: Loads all TPC-DS tables
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6877/3/testdata/workloads/functional-query/queries/QueryTest/seq-writer.test
File testdata/workloads/functional-query/queries/QueryTest/seq-writer.test:

Line 101: where ss_sold_date_sk between 2451170 and 2451200;
> Can you modify the predicate to 
Done. Also slightly adjusted the range to avoid increasing the number of rows too much.


http://gerrit.cloudera.org:8080/#/c/6877/3/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:

Line 205:   MEM_IN_MB = [20, 100, 116, 150]
> Which metrics are these?  Relationships?  Why these values?
These are memory limits set on the queries to trigger MemLimitExceeded error (so as to exercise
that path). They are set to values below and above the minimum values needed for the queries.
Please see comments at line 111 and line 207 below for how the minimum memory needed for the
queries are determined.


-- 
To view, visit http://gerrit.cloudera.org:8080/6877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message