impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] Loads all TPC-DS tables
Date Tue, 23 May 2017 21:55:22 GMT
Hello Mostafa Mokhtar,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#5).

Change subject: Loads all TPC-DS tables

Loads all TPC-DS tables

This change loads the missing tables in TPC-DS. In addition,
it also fixes up the loading of the partitioned table store_sales
so all partitions will be loaded. The existing TPC-DS queries are
also updated to use the parameters for qualification runs as noted
in the TPC-DS specification. Some hard-coded partition filters were
also removed. They were there due to the lack of dynamic partitioning
in the past. Some missing TPC-DS queries are also added to this change,
including query28 which discovered the infamous IMPALA-5251.

Having all tables in TPC-DS available paves the way for us to include
all supported TPCDS queries in our functional testing. Due to the change
in the data, planner tests and the E2E tests have different results than
before. The results of E2E tests were compared against the run done with
Netezza and Vertica. The divergence were all due to the truncation behavior
of decimal types in DECIMAL_V1.

Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
M fe/src/test/java/org/apache/impala/analysis/
M testdata/bin/
M testdata/bin/
M testdata/datasets/tpcds/tpcds_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds.test
M testdata/workloads/functional-query/queries/QueryTest/seq-writer.test
M testdata/workloads/tpcds/queries/count.test
A testdata/workloads/tpcds/queries/tpcds-q1.test
M testdata/workloads/tpcds/queries/tpcds-q19.test
A testdata/workloads/tpcds/queries/tpcds-q2.test
A testdata/workloads/tpcds/queries/tpcds-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-q23-2.test
M testdata/workloads/tpcds/queries/tpcds-q27.test
A testdata/workloads/tpcds/queries/tpcds-q27a.test
A testdata/workloads/tpcds/queries/tpcds-q28.test
M testdata/workloads/tpcds/queries/tpcds-q3.test
M testdata/workloads/tpcds/queries/tpcds-q34.test
A testdata/workloads/tpcds/queries/tpcds-q4.test
M testdata/workloads/tpcds/queries/tpcds-q42.test
M testdata/workloads/tpcds/queries/tpcds-q43.test
M testdata/workloads/tpcds/queries/tpcds-q46.test
M testdata/workloads/tpcds/queries/tpcds-q47.test
M testdata/workloads/tpcds/queries/tpcds-q52.test
M testdata/workloads/tpcds/queries/tpcds-q53.test
M testdata/workloads/tpcds/queries/tpcds-q55.test
M testdata/workloads/tpcds/queries/tpcds-q59.test
M testdata/workloads/tpcds/queries/tpcds-q6.test
M testdata/workloads/tpcds/queries/tpcds-q61.test
M testdata/workloads/tpcds/queries/tpcds-q63.test
M testdata/workloads/tpcds/queries/tpcds-q65.test
M testdata/workloads/tpcds/queries/tpcds-q68.test
M testdata/workloads/tpcds/queries/tpcds-q7.test
M testdata/workloads/tpcds/queries/tpcds-q79.test
M testdata/workloads/tpcds/queries/tpcds-q88.test
M testdata/workloads/tpcds/queries/tpcds-q89.test
M testdata/workloads/tpcds/queries/tpcds-q96.test
M testdata/workloads/tpcds/queries/tpcds-q98.test
M tests/query_test/
M tests/query_test/
40 files changed, 10,467 insertions(+), 3,806 deletions(-)

  git pull ssh:// refs/changes/77/6877/5
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Greg Rahn <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Tim Wood <>

View raw message