impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Loads all TPC-DS tables
Date Tue, 23 May 2017 17:47:29 GMT
Tim Wood has posted comments on this change.

Change subject: Loads all TPC-DS tables
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6877/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

Line 1728:     assertEquals(24, resp.rows.size());
Use symbol instead of magic constant.


http://gerrit.cloudera.org:8080/#/c/6877/2/testdata/datasets/tpcds/tpcds_schema_template.sql
File testdata/datasets/tpcds/tpcds_schema_template.sql:

PS2, Line 829: 2451272
Funny constant here (and elsewhere); please document (or pref. make it a symbol).  If it's
a date, please express in human-readable date form?


http://gerrit.cloudera.org:8080/#/c/6877/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test:

This file is very long.  Any useful way it can be split up?


Line 46: |     predicates: dt.d_moy = 12, (dt.d_date_sk >= 2451149 AND dt.d_date_sk <=
2451179 OR dt.d_date_sk >= 2451514 AND dt.d_date_sk <= 2451544 OR dt.d_date_sk >=
2451880 AND dt.d_date_sk <= 2451910 OR dt.d_date_sk >= 2452245 AND dt.d_date_sk <=
2452275 OR dt.d_date_sk >= 2452610 AND dt.d_date_sk <= 2452640)
These date constants seem brittle (regardless of representation.)


http://gerrit.cloudera.org:8080/#/c/6877/3/testdata/workloads/functional-query/queries/QueryTest/seq-writer.test
File testdata/workloads/functional-query/queries/QueryTest/seq-writer.test:

Line 101: where ss_sold_date_sk between 2451170 and 2451200;
Why/when do these values change?


-- 
To view, visit http://gerrit.cloudera.org:8080/6877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message