impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Remove redundant libevent flag when building Thrift
Date Mon, 22 May 2017 18:58:19 GMT
Henry Robinson has posted comments on this change.

Change subject: Remove redundant libevent flag when building Thrift
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6904/1/source/thrift/build.sh
File source/thrift/build.sh:

Line 35
> I don't think we need libevent otherwise, right? If not, please remove from
Done - did it in a separate commit in case we ever want to revert it.


-- 
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message