impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Date Sun, 21 May 2017 04:55:16 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java
File fe/src/main/java/org/apache/impala/service/MetadataOp.java:

Line 218:     // comments[i][j] are the comments of tableNames[j] in dbs[i].
> is the comment
Done


Line 291:             comment = table.getMetaStoreTable().getParameters().get("comment");
> Is there an HMS constant for this?
Couldn't find any. Let me know if you've seen one.


http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java
File fe/src/test/java/org/apache/impala/service/FrontendTest.java:

Line 184:     Db testDb = addTestDb(dbName, "Stores tables with comments");
> Should we fix this for DB comments as well? Or does that already work as ex
Good question. Actually, the HS2 API doesn't seem to include the comment in the GetSchemas
request, so I am not sure we should include it.


-- 
To view, visit http://gerrit.cloudera.org:8080/6933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message