impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state
Date Fri, 19 May 2017 21:19:37 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5340: Query profile displays stale query state
......................................................................


Patch Set 2: Code-Review+2

> (1 comment)
 > 
 > > Any good way to regression test this?
 > 
 > Obviously its a timing issue when we'll advance query states, and
 > without a good way to control the timing tests run the risk of
 > either being flaky or being too permissive to catch bugs.
 > 
 > One observation is with this change it will always be the case that
 > after a call to ExecuteStatement (for hs2, or the equivalent for
 > beeswax), the query will have advanced past CREATED to RUNNING or
 > FINISHED (which was not the case before this patch) and after all
 > rows have been fetched the state will be FINISHED.
 > 
 > We could check for those things in tests, though I don't think
 > they're required by the hs2 (or beeswax) spec so it may change in
 > the future.

Or we could get the profile and get_state() (or GetOperationStatus()) in a loop, and ensure
that the query state reported by the profile and directly from the RPC never go "backwards"
in the allowable transitions.

I could be convinced that this is overkill, though. Really, we're kind of missing a full set
of tests for the debugserver (that should probably be run while various queries are executing),
but that's out of scope for this change.

I'll let you decide whether a specific regression test is worth the cost for this case.

-- 
To view, visit http://gerrit.cloudera.org:8080/6923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message