impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Ported native-toolchain to work on ppc64le
Date Fri, 19 May 2017 14:37:56 GMT
Tim Armstrong has posted comments on this change.

Change subject: Ported native-toolchain to work on ppc64le
......................................................................


Patch Set 4:

(1 comment)

Thanks for the changes. The code changes look good aside from one minor comment.

After that I'll need to do a build on x86 and just do some tests to make sure nothing broke
there. If you can just confirm on your own that it builds on x86 ok that would be good - it
will save us a round-trip if there is anything wrong.

http://gerrit.cloudera.org:8080/#/c/6468/4/buildall.sh
File buildall.sh:

Line 105: CRCUTIL_VERSION=440ba7babeff77ffad992df3a10c767f184e946e-p1\
Can you add the old versions back in, just inside an "if ((BUILD_HISTORICAL))". The idea is
that we can generate all of the old versions of things if needed.


-- 
To view, visit http://gerrit.cloudera.org:8080/6468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Valencia Edna Serrao <vserrao@us.ibm.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vserrao@us.ibm.com>
Gerrit-HasComments: Yes

Mime
View raw message