impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.
Date Fri, 19 May 2017 05:17:53 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6550/4/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

Line 144:   hadoop fs -put $SCHEMA_SRC_DIR/logicaltypes.parquet ${SCHEMA_DEST_DIR}/
Please rename logicaltypes.parquet to enum.parquet. The current file name could be misleading
since there are many more logical types, but this file only covers a specific one.


http://gerrit.cloudera.org:8080/#/c/6550/4/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test:

Line 68: ====
Add tests that runs a query against such a table, either in this file or somewhere else. Would
not be good if we allowed the CREATE TABLE but then running a query e.g. crashes Impala.


-- 
To view, visit http://gerrit.cloudera.org:8080/6550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jakub Kukul <jakub.kukul@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Jakub Kukul <jakub.kukul@gmail.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message