impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS <db> statement
Date Fri, 19 May 2017 01:36:58 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5259: Add REFRESH FUNCTIONS <db> statement
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6878/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

PS2, Line 628: loadJavaFunctions
> Not too strong about it but, given "REFRESH" is an interactive command wher
I'm inclined to prefer the current swallowing behavior for the following reasons:
1. It is consistent with the startup behavior.
2. If there is at least one UDF in the HMS that is somehow broken (missing/broken jar, missing
dependencies, etc.), then this entire refresh operation will fail, and the user will need
to fix *all* such problems to make refresh work.
3. I am not 100% confident I have a good understanding if what weird Java UDFs users might
have. There could be one legitimate and weird UDF that would prevent us from running REFRESH.

Overall I think the current solution is more robust. Better to debug why a specific function
failed to load, than why refresh failed completely (and you need to fix all issues to make
it work).


-- 
To view, visit http://gerrit.cloudera.org:8080/6878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3625c88bb51cca833f3293c224d3f0feb00e6e0b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message