impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state
Date Thu, 18 May 2017 22:22:06 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5340: Query profile displays stale query state
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Nice. Thanks for fixing it.

http://gerrit.cloudera.org:8080/#/c/6923/2/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

PS2, Line 413: must ensure lock_
Any chance we can DCHECK it ?


-- 
To view, visit http://gerrit.cloudera.org:8080/6923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message