impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakub Kukul (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.
Date Thu, 18 May 2017 10:21:50 GMT
Jakub Kukul has posted comments on this change.

Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

Patch Set 4:

File docs/topics/impala_parquet.xml:

PS3, Line 1154: ENUM
> Are enums logical types?
Yes, enums are logical types. The documentation for it has been missing, but I recently opened
a PR to fix this:
File fe/src/main/java/org/apache/impala/analysis/

Line 274:       // UTF8 is the type annotation Parquet uses for strings
> This comment needs to be updated. It would be good if you put a link to a s
File testdata/data/schemas/logicaltypes.parquet:

> How did you generate this file? Was it with Hive?
I generated this file from a protobuf file, using
File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test:

Line 57: create table $DATABASE.like_logicaltypes_file like parquet
> Please indicate here what the logic types in question are.

Line 66: ---- TYPES
> You'll also want to see that SELECT works, I think.
This file only contains queries that are testing table creation. Such a test probably doesn't
belong here.

Also, I am not sure if such a test is within the scope of this ticket. We just want to make
sure that parquet columns which are annotated with ENUM logical type, e.g.:
optional binary string_col (ENUM);
will end up as string columns in impala table definition, just like it is the case for un-annotated
parquet columns, e.g.:
optional binary string_col;

When an impala table is created, these columns become regular string columns and there are
already several tests for querying string columns, I think.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jakub Kukul <>
Gerrit-Reviewer: Jakub Kukul <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message