impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5166: clean up BufferPool counters
Date Tue, 16 May 2017 16:52:50 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5166: clean up BufferPool counters
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6690/6/be/src/runtime/bufferpool/reservation-tracker.cc
File be/src/runtime/bufferpool/reservation-tracker.cc:

PS6, Line 104: "InitialReservation"
does that counter still exist? or is this meant to check one of the counters being added below?


http://gerrit.cloudera.org:8080/#/c/6690/6/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS6, Line 228: Reservation=5.00 MB
is it not useful to indicate how much of the reservation is actually in use as well? don't
need to add it to this change but wondering if that will help with tuning reservations in
extreme cases.


-- 
To view, visit http://gerrit.cloudera.org:8080/6690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message