impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5166: clean up BufferPool counters
Date Tue, 16 May 2017 16:26:37 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5166: clean up BufferPool counters
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc
File be/src/runtime/bufferpool/buffer-pool.cc:

PS3, Line 279: profile->GetOrCreateChild
> Right, but why not just add that (or use the existing AddChid() pattern)?
:S forgot what was in my own patch. 

Switched to CreateChild() and using an existing API in buffer-pool-test. I think CreateChild()
is a better API than AddChild() because it doesn't require threading the ObjectPool through
- there's no logical reason I can see that the child profile would have a different lifetime
to its parent.


http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS3, Line 237: BufferPoolUsed
> update
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message