impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5246: Verify that a UDF test completely finishes before moving on
Date Mon, 15 May 2017 23:40:10 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-5246: Verify that a UDF test completely finishes before moving on
......................................................................


Patch Set 1:

Not sure what you mean, why would you expect there to be a problem in that file? util.py is
not even a test, it's a tool for running shell tests. Do you think that all shell tests might
suffer from this?

Also, I ran a private ASAN build that passed, so I guess they are not affected.

-- 
To view, visit http://gerrit.cloudera.org:8080/6893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555b5327945c522f70f449caa1214ee0bfd84fe
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message