impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4764: Add Hedged read metrics
Date Mon, 15 May 2017 22:57:33 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4764: Add Hedged read metrics
......................................................................


IMPALA-4764: Add Hedged read metrics

The following Hadoop metrics have been added to the /metrics page:

hedgedReadOps - the number of hedged reads that have occurred

hedgedReadOpsWin - the number of times the hedged read returned
faster than the original read

The metrics will be updated only when --use_hdfs_pread is set to
'true'.

This change depends on the following new commit to HDFS:
https://github.com/apache/hadoop/commit/8c81a16a1fa40d3a3796b1c3633328f1340883ca

Testing: Not adding tests since it requires some custom hadoop
configuration. Tested manually by setting the configurations and
verifying that the metrics work.

Change-Id: Id4a5d396abb3373d352ad2df8c2272db018114da
Reviewed-on: http://gerrit.cloudera.org:8080/6886
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Reviewed-by: Lars Volker <lv@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/disk-io-mgr-scan-range.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
4 files changed, 56 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, but someone else must approve
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4a5d396abb3373d352ad2df8c2272db018114da
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message