impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4623: Enable file handle cache
Date Sat, 13 May 2017 23:13:31 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4623: Enable file handle cache

Patch Set 8:

File be/src/runtime/disk-io-mgr-handle-cache.h:

Line 88:   /// with a call to ReleaseFileHandle to release exclusive control.
this should also evict handles if a more recent mtime for a file with existing cache entries
is being requested (rather than waiting for them to age out).

Line 98:   static const uint32_t HASH_SEED = 0x87654321;
where from?
File be/src/runtime/disk-io-mgr-handle-cache.inline.h:

Line 65:   // Keep going until find unused entry with the same mtime
fix grammar

Line 113:   // to its place in the map
add it?

Line 117:     if (elem->fh.get() == fh) {
single line

Line 129:   // File can be unbuffered
where does the corresponding buffering take place?

this looks asymmetrical.
File be/src/runtime/

Line 417:       int last_read = -1;
what does this mean? does it count anything, and if so, what?

Line 429:             return Status(GetHdfsErrorMsg("Error seeking HDFS file: ", file_));
also print position

Line 435:         return Status(GetHdfsErrorMsg("Error reading from HDFS file: ", file_));
leave todo that you need to retry once to deal with stale cache entries

Line 549:         remote_bytes_ += stats->totalBytesRead - stats->totalLocalBytesRead;
why can't remote_bytes_ go into reader_?
File be/src/runtime/

Line 1300
this comment disappeared.

why is this being called?

Line 278:     cached_read_options_(nullptr),
move into .h file and remove here
File be/src/runtime/disk-io-mgr.h:

Line 494:     /// times for a scan range, it is necessary to keep some state about whether
the descriptions makes it sounds as if you need a flag, not a count.
File be/src/runtime/disk-io-mgr.h:

Line 498:     int64_t remote_bytes_;
File tests/query_test/

Line 74:     self.execute_query_expect_success(self.client, count_query)
this should give some expected result

Line 99:     self.execute_query_expect_success(self.client, count_query)
you should check for the expected result, depending on the modification type

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message