impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created
Date Sat, 13 May 2017 01:00:01 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-5167: Reduce the number of Kudu clients created
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6792/5/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

Line 403:   std::vector<std::string> sorted_master_addresses(master_addresses);
no std:: in .cc


Line 404:   sort(sorted_master_addresses.begin(), sorted_master_addresses.end());
do we need this/do we really need to worry about getting asked for a client for the same addresses
but in different order?


http://gerrit.cloudera.org:8080/#/c/6792/5/fe/src/main/java/org/apache/impala/util/KuduUtil.java
File fe/src/main/java/org/apache/impala/util/KuduUtil.java:

Line 72:   private static Map<String, KuduClient> kuduClients = Maps.newHashMap();
move above the function comment.
follow formatting rules for member variables.
add comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/6792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message