impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5318: Generate access events with fully qualified table names
Date Fri, 12 May 2017 21:42:20 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5318: Generate access events with fully qualified table names
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6879/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:

Line 107:       String fqTableName = tableName_.isFullyQualified() ? tableName_.toString()
:
> use analyzer.getFqTableName();
Done


http://gerrit.cloudera.org:8080/#/c/6879/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java:

Line 466:     Analyzer analyzer = createAnalyzer(Catalog.DEFAULT_DB);
> call the new AnalyzeAccessEvents() with Catalog.DEFAULT_DB
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd63f7e4accc7fda9719e13059fa8d432981618a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message