impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
Date Fri, 12 May 2017 18:45:13 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/java/org/apache/impala/util/KuduUtil.java
File fe/src/main/java/org/apache/impala/util/KuduUtil.java:

Line 206:     toUnixTimeExpr.analyze(analyzer);
> you could also use a local analyzer (meaning new analyzer) here, no? that w
I don't follow. If I create new Analyzer in this function, that would still need to take a
catalog and queryCtx as parameters, so wouldn't I need to pass those as parameters? If that's
the case that wouldn't save me a parameter to this function, if that's what you're suggesting.

I also need the query ctx when calling EvalExprWithoutRow.


-- 
To view, visit http://gerrit.cloudera.org:8080/6789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08b6c8354a408e7beb94c1a135c23722977246ea
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message