impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5304: reduce transfer of Parquet decompression buffers
Date Fri, 12 May 2017 18:43:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5304: reduce transfer of Parquet decompression buffers
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6876/2/be/src/exec/parquet-column-readers.cc
File be/src/exec/parquet-column-readers.cc:

Line 1029: Status BaseScalarColumnReader::ReadDataPage() {
Not necessarily for this patch, but we could also consider setting stream_->set_contains_tuple_data(false)
to avoid unnecessarily attaching I/O buffers.


Line 1037:     decompressed_data_pool_->FreeAll();
Why not Reset()?


http://gerrit.cloudera.org:8080/#/c/6876/2/be/src/exec/parquet-column-readers.h
File be/src/exec/parquet-column-readers.h:

Line 474:   bool CurrentPageContainsTupleData() {
Also not true if pages are compressed.


-- 
To view, visit http://gerrit.cloudera.org:8080/6876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dbd749f43078b222ff8e1ddcec840986c466de6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message