impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5291: avoid calling global destructors in statestore-test
Date Fri, 12 May 2017 05:12:59 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5291: avoid calling global destructors in statestore-test
......................................................................


IMPALA-5291: avoid calling global destructors in statestore-test

The workaround implemented by this patch is to exit the process using
_exit(), which does not run global destructors.

The "proper" solution would be either to change Thrift so that the
destructors are not run unnecessarily on process teardown, or to extend
the statestore services and clients to allow stopping them. It seems the
complexity of neither is justified.

Testing:
Was able to reproduce the bug by running statestore-test in a loop.
After the fix it was not reproducible.

Change-Id: Ic185825cf262311bdc05784ebd541cf53a13cdd6
Reviewed-on: http://gerrit.cloudera.org:8080/6872
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/statestore/statestore-test.cc
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic185825cf262311bdc05784ebd541cf53a13cdd6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message