impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
Date Fri, 12 May 2017 01:25:32 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
......................................................................


Patch Set 2:

(2 comments)

preliminary comments

http://gerrit.cloudera.org:8080/#/c/6849/2//COMMIT_MSG
Commit Message:

Line 14:   partition cast('2009-01-02 00:00:00' as timestamp) <= VALUES <
hm, would be nice to do an implicit cast when you see a string but want a timestamp


http://gerrit.cloudera.org:8080/#/c/6849/2/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test:

Line 174:   partition cast('2009-01-02 00:00:00' as timestamp) <= VALUES <
i forgot: does the code check for overlaps somewhere?


-- 
To view, visit http://gerrit.cloudera.org:8080/6849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae409b6106c073b038940f0413ed9d5859daaeff
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message