impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
Date Thu, 11 May 2017 23:11:16 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6849/1//COMMIT_MSG
Commit Message:

Line 9: Adds support in DDL for timestamps in Kudu range partition syntax.
> It would be nice to have an example query here.
Done


http://gerrit.cloudera.org:8080/#/c/6849/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

Line 1915:   public void TestAlterKuduTable() {
> Add timestamp tests here
I have EE tests for this because (a) I can verify that the conversion is handled correctly
and (b) we don't have any tables in the functional schema that have a TS range predicate,
so no tables that I can target here (the EE test creates the table).


PS1, Line 2319:  
> whitespace
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae409b6106c073b038940f0413ed9d5859daaeff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message