impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5166: clean up BufferPool counters
Date Thu, 11 May 2017 21:10:50 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5166: clean up BufferPool counters
......................................................................


Patch Set 3:

(1 comment)

I'm going to work on rebasing my buffer pool execution changes onto this and the other in-flight
changes so that I can do the before/after

http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc
File be/src/runtime/bufferpool/buffer-pool.cc:

PS3, Line 279: profile->GetOrCreateChild
> why would 'profile' already have a "Buffer pool" child?
RuntimeProfile doesn't have a GetChild() method and on balance it didn't seem worth adding
a new method when this was sufficient.


-- 
To view, visit http://gerrit.cloudera.org:8080/6690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message