impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers
Date Thu, 11 May 2017 00:01:57 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5238: transfer reservations between trackers
......................................................................


Patch Set 6:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/6708/6/be/src/runtime/bufferpool/reservation-tracker.cc
File be/src/runtime/bufferpool/reservation-tracker.cc:

PS6, Line 230: common_ancestor
this is named based on the state it holds after the loop, whereas the path_to_* are named
based on the state before the loop. I'd raname those to path_to_common or something to be
consistent.


Line 242:   //    trackers under 'other', down to 'this'.
in this case, common_ancestor == other, right?


Line 245:   //    under 'this', down to 'other'.
likewise


Line 260:     locks.emplace_back(tracker->lock_);
missing braces


Line 289:   if (common_ancestor == this) {
isn't this case 2?


PS6, Line 294: Case 2
case 1?


http://gerrit.cloudera.org:8080/#/c/6708/6/be/src/runtime/bufferpool/reservation-tracker.h
File be/src/runtime/bufferpool/reservation-tracker.h:

PS6, Line 213: bool
static, or make it a method on subtree1


PS6, Line 232: subtrees
is this about locking subtrees, or paths?


-- 
To view, visit http://gerrit.cloudera.org:8080/6708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message