impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created
Date Wed, 10 May 2017 20:57:33 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5167: Reduce the number of Kudu clients created
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

> How about a rebase?

Done

http://gerrit.cloudera.org:8080/#/c/6792/3/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

PS3, Line 403:   std::vector<std::string> sorted_master_addresses(master_addresses);
             :   sort(sorted_master_addresses.begin(), sorted_master_addresses.end());
             :   std::string master_addr_concat = join(sorted_master_addresses, ",");
             :   lock_guard<SpinLock> l(kudu_client_map_lock_);
> can't you just use the copy constructor?
Done


http://gerrit.cloudera.org:8080/#/c/6792/3/be/src/runtime/exec-env.h
File be/src/runtime/exec-env.h:

PS3, Line 193: across
> spelling
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message