impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Date Wed, 10 May 2017 19:46:45 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4166: Add SORT BY sql clause

Patch Set 22:

File common/thrift/JniCatalog.thrift:

Line 382:   // Optional list of sort by columns for the new table. If specified, these will
"sort columns" or "sorting columns" (as in: partition columns)

Line 385:   9: optional list<string> sort_by_columns

Line 439:   16: optional list<string> sort_by_columns
File fe/src/main/cup/sql-parser.cup:

Line 336: nonterminal ArrayList<String> opt_ident_list, opt_sort_by_cols;
opt_sort_by_clause or opt_sort_cols? "sort by columns" sounds odd.
File fe/src/main/java/org/apache/impala/analysis/

Line 43: public class AlterTableSortByColumnsStmt extends AlterTableStmt {
drop "columns", the statement doesn't include a COLUMNS

Line 73:     // Disallow setting sort by columns on HBase and Kudu tables.
rephrase "sort by columns" as "sort columns" universally

Line 91:   public static void analyzeSortByColumns(List<String> sortByCols, Table table)
maybe move this into TableDef as well? it seems kind of arbitrary to put it here.
File fe/src/main/java/org/apache/impala/analysis/

Line 863:         // TODO: Remove this when removing the sortby() hint (IMPALA-5157).
is this going to happen soon?
File fe/src/main/java/org/apache/impala/analysis/

Line 46:  * correspond to the following clauses in a CREATE TABLE statement:

Line 343:     final String sortByKey = AlterTableSortByColumnsStmt.TBL_PROP_SORT_BY_COLUMNS;
why final?
File fe/src/main/java/org/apache/impala/analysis/

Line 75:     final String sortByKey = AlterTableSortByColumnsStmt.TBL_PROP_SORT_BY_COLUMNS;
it feels like that constant should live somewhere else
File fe/src/main/java/org/apache/impala/catalog/

Line 456:    * the caller must make sure that the value matches any columns he/she added to
or "that were added to the table" to avoid the gender reference :)
File fe/src/test/java/org/apache/impala/planner/

Line 101:     addTestTable("create table test_sort_by.alltypes (id int, int_col int, " +
why call this alltypes? it clearly doesn't contain all types.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75
Gerrit-PatchSet: 22
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message