impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
Date Wed, 10 May 2017 18:48:28 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
......................................................................


Patch Set 3: Code-Review+2

> I measured the max rss w/ this change to be 88mb, down from 14gb is
 > what I observed with the old code.

it might still fail with vm_overcommit = 2 (https://www.kernel.org/doc/Documentation/vm/overcommit-accounting)
but I agree this is the best way out.

-- 
To view, visit http://gerrit.cloudera.org:8080/6842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31f03e7a4d5d237a1183277c988f85a992396a43
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message