impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
Date Wed, 10 May 2017 17:55:28 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6842/1/be/src/runtime/free-pool-test.cc
File be/src/runtime/free-pool-test.cc:

PS1, Line 132: 1LL
Will 2LL be too much ? I was hoping we could exercise the code for 64-bit allocation size.


PS1, Line 138: memset(p1, 1, size);
I wonder if we will be less prone to the problem if we don't actually memset() the entire
chunk of memory.


-- 
To view, visit http://gerrit.cloudera.org:8080/6842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31f03e7a4d5d237a1183277c988f85a992396a43
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message