impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
Date Wed, 10 May 2017 04:32:53 GMT
Henry Robinson has submitted this change and it was merged.

Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
......................................................................


IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)

See https://github.com/HenryR/gflags/tree/hidden_flags

for the commit that this patch was generated from.

Change-Id: I48d718bac3dbf548cdaefc70f8f497bbebe30da6
---
M buildall.sh
A source/gflags/gflags-2.2.0-patches/0001-Allow-hidden-flags-e.g.-DEFINE_int32_hidden.patch
2 files changed, 346 insertions(+), 2 deletions(-)

Approvals:
  Henry Robinson: Verified
  Matthew Jacobs: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48d718bac3dbf548cdaefc70f8f497bbebe30da6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message