impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5166: clean up BufferPool counters
Date Tue, 09 May 2017 21:37:43 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5166: clean up BufferPool counters
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6690/3//COMMIT_MSG
Commit Message:

Line 9: Misc changes to improve usability of the profiles.
could you post a couple screenshots of the affected profiles/pages before and after so we
can see what things look like?


http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/bufferpool/buffer-pool.cc
File be/src/runtime/bufferpool/buffer-pool.cc:

PS3, Line 279: profile->GetOrCreateChild
why would 'profile' already have a "Buffer pool" child?


http://gerrit.cloudera.org:8080/#/c/6690/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS3, Line 237: BufferPoolUsed
update


-- 
To view, visit http://gerrit.cloudera.org:8080/6690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34b7f4d94c3d396ac89026c7559d6b2c6e02697c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message