impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool
Date Tue, 09 May 2017 20:48:26 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5169: Add support for async pins in buffer pool
......................................................................


Patch Set 5:

(4 comments)

Didn't get all the way through but probably better to finish after you make the async_pin_in_flight
change.

http://gerrit.cloudera.org:8080/#/c/6612/7/be/src/runtime/buffered-tuple-stream-v2.cc
File be/src/runtime/buffered-tuple-stream-v2.cc:

PS7, Line 440: Asynchronous pins are used
This kind of implies there are synchronous pins, so let's reword to be clearer: Pins are asynchronous
... . We won't block on these read I/Os until NextReadPage(), ...


http://gerrit.cloudera.org:8080/#/c/6612/7/be/src/runtime/bufferpool/buffer-pool-internal.h
File be/src/runtime/bufferpool/buffer-pool-internal.h:

PS7, Line 46:  
on the read I/O


PS7, Line 47: the buffe
indentation


http://gerrit.cloudera.org:8080/#/c/6612/5/be/src/runtime/bufferpool/buffer-pool.h
File be/src/runtime/bufferpool/buffer-pool.h:

Line 415:   bool async_pin_in_flight() const;
> BufferedTupleStreamV2::Close() uses it. The problem this solves is in deter
As we discussed, let's not expose this, but instead use the read_page() to know which buffers
should be extracted and which should be destroyed.


-- 
To view, visit http://gerrit.cloudera.org:8080/6612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf074c1ac4405d6f08d623ba438a85f7d39fd79
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message