impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created
Date Tue, 09 May 2017 16:39:05 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5167: Reduce the number of Kudu clients created
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/6792/1//COMMIT_MSG
Commit Message:

Line 15: queries, and a map in KuduUtil to be used acress the FE
> can you add a comment about why it's OK to use the Kudu client in this way 
Done


Line 22: 
> how about validation that there are no correctness issues with concurrent u
Turns out we already have a test that covers this -
 test_kudu_alter_table (it doesn't have to be concurrent). I've also manually verified.


http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

Line 77:     : DataSink(row_desc),
> set client_ nullptr
Done


Line 148:     // Close() releases memory if client_ is not NULL, but since the memory was
consumed
> use nullptr here and below
Done


http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exprs/kudu-partition-expr.cc
File be/src/exprs/kudu-partition-expr.cc:

Line 50:       table_desc_->kudu_master_addresses(), &client));
> ExecEnv::GetInstance()
Done


http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/runtime/exec-env.h
File be/src/runtime/exec-env.h:

Line 131:   /// internally and return a pointer to it. All KuduClients accessed through this
> "look up" (lookup is a noun)
Done


http://gerrit.cloudera.org:8080/#/c/6792/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 123: export IMPALA_KUDU_VERSION=238249c
> we should keep the version bumps in their own changes in case we need to ch
Sorry, didn't mean to include this.


-- 
To view, visit http://gerrit.cloudera.org:8080/6792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message