impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test
Date Tue, 09 May 2017 01:25:04 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5245: fix ASAN buffer-allocator-test
......................................................................


IMPALA-5245: fix ASAN buffer-allocator-test

* Use the allocator_may_return_null=1 ASAN option so that the allocation
  just fails instead of crashing the process.
* Work around an bug in the implementation of the option where
  posix_memalign() does not return ENOMEM. I filed an upstream bug
  https://bugs.llvm.org/show_bug.cgi?id=32968.

Change-Id: I2f295f841b8b6e7996d54bdf2dfc0a092dcb864c
Reviewed-on: http://gerrit.cloudera.org:8080/6819
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/bufferpool/buffer-allocator-test.cc
M be/src/runtime/bufferpool/system-allocator.cc
M be/src/testutil/mem-util.h
M be/src/util/aligned-new.h
M be/src/util/bloom-filter.cc
M bin/run-backend-tests.sh
M bin/start-catalogd.sh
M bin/start-impalad.sh
M bin/start-statestored.sh
9 files changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f295f841b8b6e7996d54bdf2dfc0a092dcb864c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message