impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes
Date Mon, 08 May 2017 22:38:01 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5207,IMPALA-5214: distcc fixes
......................................................................


IMPALA-5207,IMPALA-5214: distcc fixes

enable_distcc should reset IMPALA_DISTCC_ENABLED, otherwise
disable_distcc is not reversible.

Remove the requirement of a toolchain at /opt/Impala-Toolchain. We can
easily identify paths starting with $IMPALA_TOOLCHAIN and remap them in
distcc.sh.

Testing:
Did a local build with distcc with IMPALA_TOOLCHAIN at a different
location. Tried toggling disable_distcc and enable_distcc.

Change-Id: Ic6456d0101cd15287c543cb576be6cd2391f1f26
Reviewed-on: http://gerrit.cloudera.org:8080/6655
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/distcc/README.md
M bin/distcc/distcc.sh
M bin/distcc/distcc_env.sh
3 files changed, 12 insertions(+), 25 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved
  Tim Armstrong: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/6655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6456d0101cd15287c543cb576be6cd2391f1f26
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message