impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip
Date Mon, 08 May 2017 20:06:35 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5287: Test skip.header.line.count on gzip
......................................................................


Patch Set 2:

(1 comment)

Thanks for the review comments and the good suggestions. Please see PS 3.

http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

PS1, Line 688: 
> I didn't realize there was magic that changed the default database dependin
Cool idea. I did this.


-- 
To view, visit http://gerrit.cloudera.org:8080/6817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message