impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip
Date Mon, 08 May 2017 20:00:44 GMT
Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6817

to look at the new patch set (#2).

Change subject: IMPALA-5287: Test skip.header.line.count on gzip
......................................................................

IMPALA-5287: Test skip.header.line.count on gzip

This change adds the capability to supply a dict 'test_file_vars' to
run_test_case(). Keys in this dict will be replaced with their values
inside test queries before they are executed.

Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70
---
A testdata/data/table_with_header.gz
A testdata/data/table_with_header_2.gz
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/hdfs-text-scan-with-header.test
M tests/common/impala_test_suite.py
M tests/query_test/test_scanners.py
7 files changed, 46 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/6817/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message