impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate
Date Fri, 05 May 2017 23:20:19 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3654: Parquet stats filtering for IN predicate
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6810/2/testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test
File testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test:

Line 66: and float_col IN (select float_col from functional_parquet.alltypessmall)
Let's leave this out, this get transformed into a join before we even reach HdfsScanNode.init().
Not having this makes the test case easier to read.


-- 
To view, visit http://gerrit.cloudera.org:8080/6810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a88963a7206f40a867e49eceeaf03fdd4f71997
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message